This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: Remove CYG_FAIL from AT91 serial driver
- From: Andrew Lunn <andrew at lunn dot ch>
- To: Jim Seymour <ecosjim at cipher dot com>
- Cc: ecos-patches at ecos dot sourceware dot org
- Date: Fri, 1 Jun 2007 20:30:23 +0200
- Subject: Re: Remove CYG_FAIL from AT91 serial driver
- References: <46605F93.4050708@cipher.com>
On Fri, Jun 01, 2007 at 11:04:03AM -0700, Jim Seymour wrote:
> This patch does two things:
> (.../packages/devs/serial/arm/at91/current/src/at91_serial.c)
>
> 1) It eliminates a CYG_FAIL call when the serial receiver fills up.
> 2) It eliminates a compiler warning when setting the "end" variable
Looks good.
I think this is your first patch?
It is simple enough that we don't need a copyright assignment.
Please could you provide a ChangeLog entry as part of the patch.
Also, please could you make your patch relative to the packages
directory, not deep down inside the tree. Then there is less chance of
confusion as to where the patch should be applied. With this
particular patch and the previous discussion, it is not a problem, but
sometimes it can take me a while to figure out where to apply a patch.
Thanks
Andrew