This is the mail archive of the mailing list for the eCos project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Baud rate range validation in serial devices

On 7/8/07, Andrew Lunn <> wrote:
On Mon, Jun 25, 2007 at 05:00:51PM +0400, Alexander Aganichev wrote:
> Sorry, I'm an idiot :( Not tested patch well and put reverse
> conditions everywhere.
> Here is corrected patch.
> On 6/25/07, Alexander Aganichev <> wrote:
>> Hi!
>> Here is a small patch applied to the lot's of serial device drivers
>> files that validates that baud rate is within the defined table. The
>> intention of the patch is to make easier to add support for the higher
>> speeds on platforms where that could be required without need to
>> update all other platforms every time.

Could you expand on that a little bit. What is there in the current
code which does not allow this? Range checking is nice, but i don't
see how it allows you to add additional baud rates.

The patch allowing it by adding baud rate range validation :-) Just because of if you modify top level to allow faster baudrates you make think all developers that these baud rates are supported or at least properly handled, but it is not. With the validation code they will get proper error code, so at application level there should be no condition compiled code for different platforms.

WBR, Alexander

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]