This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: LPC2xxx CAN bugfixes
- From: Hans Rosenfeld <rosenfeld at grumpf dot hope-2000 dot org>
- To: ecos-patches at ecos dot sourceware dot org
- Date: Thu, 16 Aug 2007 19:03:14 +0200
- Subject: Re: LPC2xxx CAN bugfixes
- References: <20070816163126.GA17087@grumpf.hope-2000.org>
On Thu, Aug 16, 2007 at 06:31:26PM +0200, Hans Rosenfeld wrote:
> There are two bugs in the CAN driver for the LPC2xxx.
>
> One is in include/can_lpc2xxx_baudrates.h: numbers shouldn't be prefixed
> with 0 if they aren't intended to be interpreted as octal. I fixed this
> only where it actually breaks, but the rest should be changed, too.
>
> The other is in src/can_lpc2xxx.c, the definition of "info" is missing
> when only one CAN channel is configured.
I've noticed another strange thing, is there a specific reason that
tests/can_baudrates.c, tests/can_busload.c and tests/can_rx_tx.c all
#include pkgconf/devs_can_loop.h?
--
%SYSTEM-F-ANARCHISM, The operating system has been overthrown