This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: LPC2xxx patch for support of vectored interrupt controller
> > Should there also be another check like:
> >
> > CYG_ASSERT(vector <= CYGNUM_HAL_ISR_MAX &&
> > vector >= CYGNUM_HAL_ISR_MIN , "Invalid vector");
> >
> > If you pass it an invalid vector, such as 33, you end up shifting 1 by
> > 33 which i guess results in 0. The code will then set/reset the level
> > on every single interrupt!
>
> This assertion cannot fail if the previous assertion did not fail
O.K. Fine. I just asked the question, is this needed. And the answer is now clear. No.
Thanks
Andrew