This is the mail archive of the ecos-patches@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Network TCP Handler: stale socket disposal


John Mills wrote:
> Hello -
> 
> This is my first post to this group; please correct me on netiquette and
> appropriate usage as necessary. (For starters, should I have attached the
> patch instead of cutting it into my text?)
> 
> I have been dealing with a situation in which certain TCP transactions
> depleted the stock of network sockets allowed in our eCos configuration,
> eventually disabling the product from opening either incoming or outgoing
> network sockets. I believe the problem was due to the function 'sofree()'
> in 'sys/kern/uipc_socket.c' preserving any socket flagged as SS_COMP,
> whether or not it had also been flagged for reset. Adding a test of
> so->so_error for the flags set by tcp_input() has resolved the issue.
> Please examine and test the following patch and let me know if you see any
> potentially troublesome side effects. Please apply the patch to eCos
> sources if it seems to be appropriate.

Normally, patches are better sent as attachments.  This avoids
email clients causing inappropriate line breaks.

As for this particular change, do you have a test case or
some way to force the error so we can verify that it has
the desired effect?  Also, it may be the case that this
issue has been solved in the FreeBSD sources (I imported
the "current" code into eCos more than 5 years ago!).  Have
you checked into that at all?

Thanks

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]