This is the mail archive of the ecos-patches@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: CYGPKG_CPULOAD fixes


Hi Lars

John Dallaway wrote:

> Lars Povlsen wrote:
> 
>> Here's a small fix to the cpuload package (and idle thread).
>>
>> In short, a missing 'volatile' attribute to the loop counter causes
>> newer (arm-eabi GCC 4.2.3/eCosentric toolchain) to produce wrong
>> results.
>>
>> This patch adds a volatile modifier to idle_thread_loops[], and updates
>> the reference to it from the cpuload package. (which was also using a
>> non-array declaration).
> 
> This all seems reasonable. Presumably GCC 4 is holding the idle loop
> count in a register. Any other comments before I check this in?

Sanity tested on ARM and checked in. Thank you for the patch.

There are still issues with the cpuload package when built at "-O2"
optimisation. Ref:

  http://ecos.sourceware.org/ml/ecos-discuss/2007-06/msg00175.html

John Dallaway
eCos maintainer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]