This is the mail archive of the ecos-patches@sourceware.org mailing list for the eCos project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 05/06/10 15:28, Sergei Gavrikov wrote:On Sat, 5 Jun 2010, Sergei Gavrikov wrote:[snip]On Wed, 2 Jun 2010, Jay Foster wrote:The attached patch fixes tcflush() and tcdrain() in the termios package. These functions would call the fo_getinfo() function of the file system code with a 0 length (the length value is unused).[snip] This combination (non-NULL pointer to 0 value) is a special case in cyg_io_get_config() used to determine if the get_config method is available for the device. It always returns success (ENOERR) when the method is defined and does nothing.RFC: May be we need even in an one-line comment/note in termios.c to notice user about that "strange" length? Or may be to use some local macro there, e.g.
#define NOBUF_NOCHECK NULL,1
I need to have the best opinion. Jifl?
To save time on testing.
I forgot to mention that was not only 'a backtrace/code view in mind' from my side. Yesterday, I did a gDebuging a real termios example on synthetic target. So, I confirm the Jay's report and confirm that his workaround fixes the issue.
That sounds good, and I think a comment would be valuable. A #define is probably unnecessary. Thanks!
Could you, please, submit new patch with an included comment (just a few sentences)? I confess that I could not believe that tcflush() does not work :-) and only GDB passed me through out that 'll' and the check. So, I think a using those "ones" won't stick in the mind without your short notice. Thanks!
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |