This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
RE: PHY update
- From: "Christophe Coutand" <ccoutand at stmi dot com>
- To: "John Dallaway" <john at dallaway dot org dot uk>, "Sachin Sushil Chaddha" <schaddha at stmi dot com>, "Edgar Grimberg" <edgar dot grimberg at zylin dot com>
- Cc: <ecos-patches at ecos dot sourceware dot org>, <chadhas at ymail dot com>
- Date: Tue, 8 Jun 2010 05:16:07 -0700
- Subject: RE: PHY update
- References: <D6050C555CC56940A7AF32652283027602C8B980@mail2.STMIRV01.COM> <4BEA8135.6040402@dallaway.org.uk> <D6050C555CC56940A7AF32652283027601116BF4@mail2.STMIRV01.COM> <4C0E2336.5010003@dallaway.org.uk>
Hi John,
The reason for having external definitions was to keep all registers
definition in the same place. Some HW may have to configure special PHY
registers (to adjust clock delay etc..) to be able to work properly.
This work is left to the user since it is HW specific.
Currently no package rely on these header files. Let me know what you
prefer and I can submit a new patch.
Regards,
Christophe
-----Original Message-----
From: John Dallaway [mailto:john@dallaway.org.uk]
Sent: 8. juni 2010 13:02
To: Sachin Sushil Chaddha; Christophe Coutand; Edgar Grimberg
Cc: ecos-patches@ecos.sourceware.org; chadhas@ymail.com
Subject: Re: PHY update
Hi Sachin, Chrristophe and Edgar
Sachin Sushil Chaddha wrote:
> I have received my Copyright Assignment form, which is attached for
your
> reference.
That's great. Thank you.
> Christophe Coutand wrote:
>
>> Attached are some new PHY support to HAL. Vitesse VSC8244 is part of
a
>> port to Freescale 8572 evaluation board. Rest of the HAL for this
>> processor will follow.
>>
>> Let me know if the patch is correctly generated. IP101A is submitted
on
>> behalf of Edgar Grimberg @ Zylin.com and VSC864 is submitted on
behalf
>> of Sachin Sushil Chaddha @ stmi.com
Is there a reason why you have placed the PHY register definitions into
an external header file? Might they be required by other eCos packages?
If there _is_ a good reason, then we should add the standard copyright
banner to these header files and adhere to eCos file naming conventions.
Otherwise, I would suggest placing these definitions in the relevant .c
source files directly similar to the support for other PHY parts
(INLXT972.c and KSZ8041.c for example).
John Dallaway
eCos maintainer