This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: bsp for Olimex LPC-L2294-8M
- From: Jean-Francois Argentino <jf dot argentino at osean dot fr>
- To: Sergei Gavrikov <sergei dot gavrikov at gmail dot com>
- Cc: ecos-patches at sources dot redhat dot com
- Date: Mon, 08 Nov 2010 09:35:47 +0100
- Subject: Re: bsp for Olimex LPC-L2294-8M
- References: <4CD3EB1B.3000709@osean.fr> <alpine.DEB.2.00.1011051734540.23460@sg-laptop>
- Reply-to: jf dot argentino at osean dot fr
Hello,
I think that to start a process to get CA from FSF is good idea as your
both patches (the second is a fix for one FLASH device driver) have TODO
lines :-)
If you think so, I'll discuss with my boss to initiate a CA. Regarding
the TODOs, I won't have the time to fix them... Do you want me to remove
them from the patches ?
One thought according the selected name for CDL to manage a hardware
variant for the target (CYGPKG_HAL_ARM_LPC2XXX_OLPCL2294_RAMSIZE), for
my taste CDL name to distinguish hardware would be something like
CYGHWR_HAL_ARM_LPC2XXX_OLPCL2294_VARIANT and using such an option you
could enter the changes in HAL startup code and in the target's flash
device driver.
Do you think that "CYGHWR_HAL_ARM_LPC2XXX_OLPCL2294_RAMSIZE" is OK? Thus
the name (RAMSIZE) still reflect the value behind. By using
"CYGHWR_HAL_ARM_LPC2XXX_OLPCL2294_VARIANT", IMHO legal values would
better be strings "1M" and "8M", then involve some extra manipulation in
preprocessing, which solution do you prefer ?
So, could you, please, re-submit the patch(es) for eCos Bugzilla system
and start the process of obtaining CA (if you can)? At the least, I will
be able to test your changes for 8M variant on OLPCL2294-1M target then.
Are you agree that the patch about the sst FLASH memory can be
re-submited as is (maybe just removing the TODOs) through the bugzilla ?
For the OLPC-L2294-8M patch, I'll discuss with my boss about the CA and
I keep you in touch on this mailing-list.
Je vous remercie,
A pleasure to contribute.
--
Jean-François Argentino
OSEAN S.A.S
1024 Chemin des Plantades
83130 LA GARDE
FRANCE
Tél.: +33 (0)4 94 03 65 84
Fax : +33 (0)4 94 66 62 32
Web: www.osean.fr