This is the mail archive of the
mailing list for the eCos project.
[Bug 1001114] New port: NXP LPC17XX Variant, Olimex LPC-1766-STK platform
- From: bugzilla-daemon at bugs dot ecos dot sourceware dot org
- To: ecos-patches at ecos dot sourceware dot org
- Date: Sun, 6 Mar 2011 20:54:27 +0000
- Subject: [Bug 1001114] New port: NXP LPC17XX Variant, Olimex LPC-1766-STK platform
- Auto-submitted: auto-generated
- References: <email@example.com/>
Please do not reply to this email. Use the web interface provided at:
--- Comment #29 from Ilija Kocho <firstname.lastname@example.org> 2011-03-06 20:54:24 GMT ---
(In reply to comment #28)
> (In reply to comment #27)
> I get it (however, it looks a bit encrypted :-).
I admit :-/
> I have doubts about the
> "modem" signals which were turned on by default. Do you really need to
> activate them in the statrup code? About comments-memo, I would prefer
> to have (diff against your delta)
It's true, the modem signals are used very seldom, but they are wired on the
platform board LPC-17XX-STK so I decided to enable them in order to reflect the
However, if it may facilitate application of same platform port on other/custom
boards we can omit them.
For the time being I have no diff to post.
Off topic: I can see that sometimes you make diffs against /dev/null. What diff
option do you use?
> - // Enable UART0 and UART1 pins
> - // Enable pins: TXD1. .. .. .. .. .. RXD0-TXD0 ..
> - CYGHWR_HAL_LPC17XX_PIN_SET(CYGHWR_HAL_LPC17XX_REG_PINSEL0, 0x40000050);
> - // Enable pins: .. .. .. .. .RTS1 .DTR1 DSR1-DCD1 CTS1-RXD1
> - CYGHWR_HAL_LPC17XX_PIN_SET(CYGHWR_HAL_LPC17XX_REG_PINSEL1, 0x00001155);
> + // Enable UART0 and UART1
> + CYGHWR_HAL_LPC17XX_PIN_SET(CYGHWR_HAL_LPC17XX_REG_PINSEL0,
> + (1 /* TXD0 */ << 4) |
> + (1 /* RXD0 */ << 6) |
> + (1 /* TXD1 */ << 30)
> + );
> + CYGHWR_HAL_LPC17XX_PIN_SET(CYGHWR_HAL_LPC17XX_REG_PINSEL1,
> + (1 /* RXD1 */ << 0)
> + );
> But, maybe someone will have alternative view (about "modem" signals).
If you decide against modem signals, pse let me know and eventually attach a
patch so I test it on my board.
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.