This is the mail archive of the ecos-patches@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug 1001275] Cortex-M (armV7) architecture endian instructions / Applied on lwIP


Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001275

--- Comment #31 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-08-24 18:01:32 BST ---
(In reply to comment #30)

...

> I found a typo in Attachment 1349, a comment reflects older version.
> 
> Patch snippet:
> 
> -#endif // defined(CYG_CPU_TO_BE16(__val)) && defined(CYG_CPU_TO_BE32(__val))
> +#endif // defined(CYGIMP_LWIP_ENDIAN_BY_HAL) && CYGIMP_LWIP_ENDIAN_BY_HAL
> 
> I guess you can fix this manually.

Ilija, I have removed the comment yesterday :-) If idefs are not nested
and "wraps" about 1-5 lines of code I prefer to do not duplicate its
condition/check in a comment, especially if the condition is too long.
IMO, it looks clear and it's easier to read such blocks.

In any case, thank you for report.

Sergei
> 
> Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]