This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
[Bug 1001453] CAN IO package: wider flags field, flag to report return to 'error active' mode
- From: bugzilla-daemon at bugs dot ecos dot sourceware dot org
- To: ecos-patches at ecos dot sourceware dot org
- Date: Thu, 19 Jan 2012 20:45:59 +0000
- Subject: [Bug 1001453] CAN IO package: wider flags field, flag to report return to 'error active' mode
- Auto-submitted: auto-generated
- References: <bug-1001453-104@http.bugs.ecos.sourceware.org/>
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001453
--- Comment #8 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2012-01-19 20:45:54 GMT ---
(In reply to comment #7)
> Yet more needed change:
>
> - since flags will be 32 bits wide, then the flag_mask field in
> cyg_can_callback_cfg_st must be expanded too. Must do a typedef (or a
> #define?) for flags instead of using cyg_uint32, I missed the
> flag_mask expansion because of this.
>
> - in can_callbacks_t, describing the function pointers accessible to
> the low level drivers, xmt_msg is today:
>
> void (*xmt_msg)(can_channel *chan, void *pdata)
>
> I'd like to have instead:
[snip]
So far only one comment.
Still try to be very careful when planning to change generic CAN I/O
API. There is not only a dependence (LPC2XXX).
% ecosconfig list | grep DEVS_CAN
Package CYGPKG_DEVS_CAN_AT91SAM7 (AT91SAM7 CAN device drivers):
Package CYGPKG_DEVS_CAN_LOOP (Loop CAN device drivers):
Package CYGPKG_DEVS_CAN_LPC2XXX (LPC2xxx CAN device drivers):
Package CYGPKG_DEVS_CAN_MCF52xx_FLEXCAN (MCF52xx FlexCAN device drivers):
Sergei
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.