Re: [patch] Fix RLIMIT_RTPRIO in sysdeps/unix/sysv/linux/mips/bits/resource.h

[Niklaus <niklaus at gmail dot com>]

On 3/28/06, Lior Balkohen <balkohen@gmail.com> wrote:
> > Here is a trivial patch.  This typo also exists in 2.3 branch.
>
> Ping?
>
> make check fails without this patch:
>
> make  subdir=resource -C resource ..=../ tests
> make[2]: Entering directory `/home/lior/builds/mips/src/glibc-2.4/resource'
> mips-none-linux-gnu-gcc -mabi=32 tst-getrlimit.c -c -std=gnu99 -Os
> -Wall -Winline -Wwrite-strings -fmerge-all-constants -pipe
> -Wstrict-prototypes      -I../include
> -I/home/lior/builds/mips/src/build/resource
> -I/home/lior/builds/mips/src/build -I../ports/sysdeps/mips/elf
> -I../ports/sysdeps/unix/sysv/linux/mips/mips32
> -I../ports/sysdeps/unix/sysv/linux/mips/nptl
> -I../ports/sysdeps/unix/sysv/linux/mips
> -I../ports/sysdeps/unix/sysv/linux -I../nptl/sysdeps/unix/sysv/linux
> -I../nptl/sysdeps/pthread -I../sysdeps/pthread
> -I../sysdeps/unix/sysv/linux -I../sysdeps/gnu -I../sysdeps/unix/common
> -I../sysdeps/unix/mman -I../sysdeps/unix/inet
> -I../ports/sysdeps/unix/sysv -I../nptl/sysdeps/unix/sysv
> -I../sysdeps/unix/sysv -I../ports/sysdeps/unix/mips/mips32
> -I../ports/sysdeps/unix/mips -I../ports/sysdeps/unix
> -I../nptl/sysdeps/unix -I../sysdeps/unix -I../sysdeps/posix
> -I../ports/sysdeps/mips/mips32 -I../ports/sysdeps/mips
> -I../sysdeps/ieee754/flt-32 -I../sysdeps/ieee754/dbl-64
> -I../sysdeps/wordsize-32 -I../ports/sysdeps/mips/nptl
> -I../sysdeps/ieee754 -I../sysdeps/generic/elf -I../sysdeps/generic
> -I../ports -I../nptl  -I.. -I../libio -I. -nostdinc -isystem
> /home/lior/builds/mips/cdk/lib/gcc/mips-none-linux-gnu/4.1.0/include
> -isystem /home/lior/builds/mips/src/linux-2.6.16/include
> -D_LIBC_REENTRANT -include ../include/libc-symbols.h  -DPIC
> -DNOT_IN_libc=1    -o
> /home/lior/builds/mips/src/build/resource/tst-getrlimit.o -MD -MP -MF
> /home/lior/builds/mips/src/build/resource/tst-getrlimit.o.dt -MT
> /home/lior/builds/mips/src/build/resource/tst-getrlimit.o
> tst-getrlimit.c:43: error: '_RLIMIT_RTPRIO' undeclared here (not in a function)
> make[2]: *** [/home/lior/builds/mips/src/build/resource/tst-getrlimit.o] Error 1
> make[2]: Leaving directory `/home/lior/builds/mips/src/glibc-2.4/resource'
> make[1]: *** [resource/tests] Error 2
> make[1]: Leaving directory `/home/lior/builds/mips/src/glibc-2.4'
> make: *** [check] Error 2
>
>
> > Index: sysdeps/unix/sysv/linux/mips/bits/resource.h
> > ===================================================================
> > RCS file: /cvs/glibc/ports/sysdeps/unix/sysv/linux/mips/bits/resource.h,v
> > retrieving revision 1.8
> > diff -u -r1.8 resource.h
> > --- sysdeps/unix/sysv/linux/mips/bits/resource.h      20 Jun 2005 15:07:34 -0000      1.8
> > +++ sysdeps/unix/sysv/linux/mips/bits/resource.h      18 Mar 2006 22:50:36 -0000
> > @@ -98,7 +98,7 @@
> >    /* Maximum realtime priority allowed for non-priviledged
> >       processes.  */
> >    __RLIMIT_RTPRIO = 14,
> > -#define RLIMIT_RTPRIO _RLIMIT_RTPRIO
> > +#define RLIMIT_RTPRIO __RLIMIT_RTPRIO
> >
> >    __RLIMIT_NLIMITS = 15,
> >    __RLIM_NLIMITS = __RLIMIT_NLIMITS
>
I didn't find any such error in 2.3 tree.  where did you find that
error in 2.3 tree.
Well only for mips the typo wasn't fixed, all the other typos were fixed.
http://sourceware.org/ml/libc-hacker/2005-06/msg00005.html is the
original patch.