This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Plug a couple of memory leaks
- From: Samuel Thibault <samuel dot thibault at ens-lyon dot org>
- To: Roland McGrath <roland at redhat dot com>
- Cc: Emilio Pozuelo Monfort <pochu27 at gmail dot com>,libc-alpha at sources dot redhat dot com
- Date: Wed, 21 Jul 2010 11:46:04 +0200
- Subject: Re: [PATCH] Plug a couple of memory leaks
- References: <4C46234D.4060503@gmail.com> <20100721022737.027A6400B5@magilla.sf.frob.com>
Roland McGrath, le Tue 20 Jul 2010 19:27:36 -0700, a écrit :
> > Also, if calling __hurd_sockfail() after __ifsock_getsockaddr() is fine, we
> > would need to call __hurd_fail() before, since __hurd_sockfail() doesn't call
> > it. Is there a reason why it doesn't?
>
> No, you've misunderstood. __hurd_sockfail calls _hurd_fd_error, which is
> what __hurd_dfail calls. These do appropriate magic for the same special
> case RPC errors that __hurd_fail handles.
Mmm, but they don't handle KERN_NO_SPACE (ENOMEM) and
KERN_INVALID_ARGUMENT (EINVAL).
Samuel