This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] memcpy-ssse3: enable chk symbols in static builds

From: Mike Frysinger <vapier at gentoo dot org>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: libc-alpha at sourceware dot org
Date: Sun, 6 Feb 2011 17:54:23 -0500
Subject: Re: [PATCH] memcpy-ssse3: enable chk symbols in static builds
References: <1297016884-11951-1-git-send-email-vapier@gentoo.org> <AANLkTin8avECwMGMegBL5z7Kqx3ZTX=1ZjBqMOz8v+0h@mail.gmail.com>

On Sunday, February 06, 2011 17:46:45 H.J. Lu wrote:
> On Sun, Feb 6, 2011 at 10:28 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> > 2011-02-06  Mike Frysinger  <vapier@gentoo.org>
> > 
> >        * sysdeps/x86_64/multiarch/memcpy-ssse3.S: Delete SHARED ifdef
> > check around MEMCPY_CHK symbol.
> >        * sysdeps/x86_64/multiarch/memcpy-ssse3-back.S: Likewise.
> 
> I don't think it is correct.  Please try this.

i dont think either are correct now that you posted this.  the whole file is 
protected by:
#if !defined NOT_IN_libc \
    && (defined SHARED \
        || defined USE_AS_MEMMOVE \
	|| !defined USE_MULTIARCH)

so there isnt much point in checking any of these inside of that.  just delete 
the whole #if protection from the MEMCPY_CHK symbol.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Follow-Ups:
- Re: [PATCH] memcpy-ssse3: enable chk symbols in static builds
  - From: H.J. Lu

References:
- [PATCH] memcpy-ssse3: enable chk symbols in static builds
  - From: Mike Frysinger
- Re: [PATCH] memcpy-ssse3: enable chk symbols in static builds
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]