Re: [PATCH] Fix nptl semaphore cleanup invocation

[Roland McGrath <roland at hack dot frob dot com>]

> Could you be more specific about the whitespace issues?  I cut and
> pasted the code, reformatted with emacs in GNU coding style mode, and
> the function declaration matches exactly how this style of function
> with attributes is declared elsewhere in the glibc tree.
> +static int
> +__attribute__ ((noinline))
> +do_futex_timed_wait(struct new_sem *isem, struct timespec *rt)
                      ^ space here

> +/* This is in a seperate function in order to make sure gcc
> +   puts the call site into an exception region, and thus the
> +   cleanups get properly run.  */
> +static int
> +__attribute__ ((noinline))
> +do_futex_wait(struct new_sem *isem)
                ^ space here

> +/* This is in a seperate function in order to make sure gcc
> +   puts the call site into an exception region, and thus the
> +   cleanups get properly run.  */
> +static int
> +__attribute__ ((noinline))
> +do_futex_timed_wait(struct sparc_new_sem *isem, struct timespec *rt)
                      ^ space here

etc.  Check all the cases, I didn't cite every one.