This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Reduce ridiculous stack use in _dl_map_object_deps

On Mon, Oct 31, 2011 at 2:23 PM, Roland McGrath <roland@hack.frob.com> wrote:

> Use an initialized defn.

Done.

>> + ? ? ? if (new_size > needed_space_bytes)
>> + ? ? ? ? needed_space
>> + ? ? ? ? ? = extend_alloca (needed_space, needed_space_bytes, new_size);
>> +
>> + ? ? ? needed = needed_space;
>
> Something has to update needed_space_bytes.

extend_alloca does.

Thanks,
-- 
Paul Pluzhnikov

2011-10-31  Paul Pluzhnikov  <ppluzhnikov@google.com>

       * elf/dl-deps.c (_dl_map_object_deps): Reuse alloca space to reduce
       stack usage.

Attachment: glibc-excessive-stack-20111031b.txt
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]