This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Fix scalbn, scalbln integer overflow

From: "Joseph S. Myers" <joseph at codesourcery dot com>
To: Andreas Jaeger <aj at suse dot com>
Cc: libc-alpha at sourceware dot org
Date: Fri, 2 Mar 2012 15:34:30 +0000 (UTC)
Subject: Re: Fix scalbn, scalbln integer overflow
References: <Pine.LNX.4.64.1203020139040.2578@digraph.polyomino.org.uk><4F506C2E.1060807@suse.com>

On Fri, 2 Mar 2012, Andreas Jaeger wrote:

> I suggest to add a comment before k=k+n stating why it's not done earlier in
> the code so that the next person might not accidentally "optimize" it.

Committed with the comment:

        /* Now k and n are bounded we know that k = k+n does not
           overflow.  */

-- 
Joseph S. Myers
joseph@codesourcery.com

References:
- Fix scalbn, scalbln integer overflow
  - From: Joseph S. Myers
- Re: Fix scalbn, scalbln integer overflow
  - From: Andreas Jaeger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]