Re: [PATCH] Add --print-dirs option for ldconfig

[Dan Nicholson <dbn dot lists at gmail dot com>]

On Sat, Mar 31, 2012 at 02:07:56PM -0700, Roland McGrath wrote:
> > Add a -P|--print-dirs option to ldconfig for printing the linker
> > search directories. 
> 
> Seems like a reasonable feature.  But call it --print-search-dirs,
> consistent with the analogous gcc option.
> 
> > +2012-03-28  Dan Nicholson  <dbn.lists@gmail.com>
> > +
> > +	* elf/ldconfig.c: Add option to print linker path.
> 
> This log entry needs to be specific about the variables and functions
> touched.
> 
> > +  if (opt_print_dirs)
> > +    {
> > +      struct dir_entry *entry;
> > +
> > +      for (entry = dir_entries; entry != NULL; entry = entry->next)
> 
> You can (and should) always use C99 syntax in glibc code.
> So write:
> 
>     if (...)
>       for (struct dir_entry *entry = dir_entries; entry != NULL; entry = entry->next)

OK, updated patch attached. Hopefully it addresses both comments, but
I don't have a ton of experience with GNU ChangeLog format. Let me
know if there's any further changes you'd like to see.

--
Dan

Attachment: print-dirs-v2.patch
Description: Text document