This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] BZ #14059 - HAS_FMA4 check needs to also check for AVX

From: Jeff Law <law at redhat dot com>
To: "Carlos O'Donell" <carlos at systemhalted dot org>
Cc: Andreas Jaeger <aj at suse dot de>, libc-alpha at sourceware dot org
Date: Fri, 11 May 2012 14:36:09 -0600
Subject: Re: [PATCH] BZ #14059 - HAS_FMA4 check needs to also check for AVX
References: <hopqaf6pz3.fsf@byrd.suse.de> <CADZpyiyWVvZ0Z8+98rqfYYdWKKXEPVGpt18b=UbDnvfHM-50JA@mail.gmail.com> <CADZpyiycOx29T2-w2ctaoGz0jn6ZFPuiVRsSAN_=oKu1hV5y+g@mail.gmail.com> <4FACB302.2010407@suse.de> <CADZpyiyGONFHBvFt+HKvAB18+iCmL+f8mpN6=WTVJv2eESiw5A@mail.gmail.com> <4FAD22A8.4080405@redhat.com> <CADZpyiwJm7gV201hEk3-L7sEh8Yxdg8Uu83pRA_X3hBbA0f4xA@mail.gmail.com>

On 05/11/2012 09:22 AM, Carlos O'Donell wrote:

On Fri, May 11, 2012 at 10:31 AM, Jeff Law<law@redhat.com> wrote:
On 05/11/2012 06:05 AM, Carlos O'Donell wrote:
Here's a combined patch that compiled fine for me on
Linux/x86-64. Jeff, could you test it under Xen, please?
I've finally got functional access to a box which exhibits the problem; so
yes, I'll take this patch for a spin and report back.
Would you test this final unified patch?

This patch doesn't work. It causes infinite mutual recursion between init_cpu_features and get_cpu_features.

AFAICT, you can't use the CPUID_XXX macros (which call get_cpu_features) until init_cpu_features is complete.

jeff

Follow-Ups:
- Re: [PATCH] BZ #14059 - HAS_FMA4 check needs to also check for AVX
  - From: Carlos O'Donell

References:
- [PATCH] BZ #14059 - HAS_FMA4 check needs to also check for AVX
  - From: Andreas Jaeger
- Re: [PATCH] BZ #14059 - HAS_FMA4 check needs to also check for AVX
  - From: Carlos O'Donell
- Re: [PATCH] BZ #14059 - HAS_FMA4 check needs to also check for AVX
  - From: Carlos O'Donell
- Re: [PATCH] BZ #14059 - HAS_FMA4 check needs to also check for AVX
  - From: Andreas Jaeger
- Re: [PATCH] BZ #14059 - HAS_FMA4 check needs to also check for AVX
  - From: Carlos O'Donell
- Re: [PATCH] BZ #14059 - HAS_FMA4 check needs to also check for AVX
  - From: Jeff Law
- Re: [PATCH] BZ #14059 - HAS_FMA4 check needs to also check for AVX
  - From: Carlos O'Donell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]