Re: fanotify_mark

[Thomas Schwinge <thomas at codesourcery dot com>]

Hi!

On Mon, 11 Jun 2012 09:46:08 +0200, Andreas Schwab <schwab@linux-m68k.org> wrote:
> diff --git a/sysdeps/unix/sysv/linux/sh/syscalls.list b/sysdeps/unix/sysv/linux/sh/syscalls.list
> index be9ffed..a8b4fb6 100644
> --- a/sysdeps/unix/sysv/linux/sh/syscalls.list
> +++ b/sysdeps/unix/sysv/linux/sh/syscalls.list
> @@ -3,3 +3,4 @@
>  waitpid		-	waitpid		Ci:ipi	__waitpid	waitpid	__libc_waitpid
>  
>  prlimit64	EXTRA	prlimit64	i:iipp	prlimit64
> +fanotify_mark	EXTRA	fanotify_mark	i:iiiiis	__fanotify_mark fanotify_mark@@GLIBC_2.16

Thanks!  It didn't occur to me the possibility to use a symbol version
here.  Yes, that appears to work nicely, so I'm planning to commit that
(together with the libc.abilist update) unless someone else sees any
problem with that approach.

    $ install/bin/*-objdump -t install/sh-linux-gnu/libc/usr/lib/libc.a | grep fanotify_mark
    fanotify_mark.o:     file format elf32-sh-linux
    00000000 g     F .text  00000038 __fanotify_mark
    00000000 g     F .text  00000038 fanotify_mark@@GLIBC_2.16
    $ echo 'int main(){fanotify_mark();}' | install/bin/*-gcc -static -x c - && install/bin/*-objdump -t a.out | grep fanotify_mark
    0040a160 g     F .text  00000038 __fanotify_mark
    0040a160 g     F .text  00000038 fanotify_mark@@GLIBC_2.16
    $ ssh mia $PWD/a.out && echo OK
    OK

    $ install/bin/*-objdump -Tt install/sh-linux-gnu/libc/lib/libc.so.6 | grep fanotify_mark
    000b3620 l     F .text  00000050              __fanotify_mark
    000b3620 l     F .text  00000050              __GI___fanotify_mark
    000b3620 g     F .text  00000050              fanotify_mark@@GLIBC_2.16
    000b3620 g    DF .text  00000050  GLIBC_2.16  fanotify_mark
    $ echo 'int main(){fanotify_mark();}' | install/bin/*-gcc -x c - && install/bin/*-objdump -tT a.out | grep fanotify_mark
    00400320       F *UND*  00000000              fanotify_mark@@GLIBC_2.16
    00400320      DF *UND*  00000000  GLIBC_2.16  fanotify_mark
    $ ssh mia $PWD/a.out && echo OK
    [...]/a.out: /lib/libc.so.6: version `GLIBC_2.16' not found (required by [...]/a.out)
    $ ssh mia "$PWD/install/sh-linux-gnu/libc/lib/ld-linux.so.2 --library-path $PWD/install/sh-linux-gnu/libc/lib:$PWD/install/sh-linux-gnu/libc/usr/lib $PWD/a.out" && echo OK
    OK


GrÃÃe,
 Thomas

Attachment: pgp00000.pgp
Description: PGP signature