This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add TLS reloc defines for AM33


On 08/07/2012 05:01 PM, Mark Salter wrote:
2012-08-07 Mark Salter <msalter@redhat.com>

* elf/elf.h: Define AM33 (MN10300) TLS relocs.

Signed-off-by: Mark Salter <msalter@redhat.com>
---
  elf/elf.h | 14 +++++++++++++-
  1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/elf/elf.h b/elf/elf.h
index 71cfdb8..8ad893b 100644
--- a/elf/elf.h
+++ b/elf/elf.h
@@ -2734,8 +2734,20 @@ typedef Elf32_Addr Elf32_Conflict;
  #define R_MN10300_GLOB_DAT	21	/* Create GOT entry.  */
  #define R_MN10300_JMP_SLOT	22	/* Create PLT entry.  */
  #define R_MN10300_RELATIVE	23	/* Adjust by program base.  */
+#define R_MN10300_TLS_GD	24	/* 32 bit offset for global dynamic */

Nitpicking:


I know we're not consistent in this file but suggest to follow the proper standard for comments like the other am33 entries above do as well - capitalize the first word at least. Should those have a "." and two spaces at the end as well like the others? They are not complete sentences but neither are the ones above,

Andreas

+#define R_MN10300_TLS_LD	25	/* 32 bit offset for local dynamic */
+#define R_MN10300_TLS_LDO	26	/* module-relative offset */
+#define R_MN10300_TLS_GOTIE	27	/* GOT offset for static TLS block
+					   offset */
+#define R_MN10300_TLS_IE	28	/* GOT address for static TLS block
+					   offset */
+#define R_MN10300_TLS_LE	29	/* Offset relative to static TLS
+					   block */
+#define R_MN10300_TLS_DTPMOD	30	/* ID of module containing symbol */
+#define R_MN10300_TLS_DTPOFF	31	/* Offset in module TLS block */
+#define R_MN10300_TLS_TPOFF	32	/* Offset in static TLS block */

-#define R_MN10300_NUM		24
+#define R_MN10300_NUM		33


/* M32R relocs. */




--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]