Re: Patch for x86_32: Fix bug 14195

[Dmitrieva Liubov <liubov dot dmitrieva at gmail dot com>]

Updated patch with a test-case is attached, please review it.

ChangeLog:

2012-08-13  Liubov Dmitrieva  <liubov.dmitrieva@gmail.com>

         * sysdeps/i386/i686/multiarch/strcmp-sssse3.S: BZ #14195
         Fix segmentation fault for a case of two empty input strings.
         * string/test-strncasecnp.c: Update.
         Add a test-case for two empty input strings and N > 0

--
Liubov Dmitrieva
Intel Corporation

>> Does the testsuite catch this?

>> If it doesn't, could you please add a case which will prevent this from
>> regressing in the future?

>> Comparing two empty strings seems like a corner-case we should be testing.

>> Cheers,
>> Carlos.

2012/8/10 Roland McGrath <roland@hack.frob.com>:
>> 2012-08-10  Liubov Dmitrieva  <liubov.dmitrieva@gmail.com>
>>
>>         * sysdeps/i386/i686/multiarch/strcmp-sssse3.S: Update
>>         Fix bug 14195
>
> This log entry is insufficient, as well as not fitting conventions.
> The mention of a bug number is as "[BZ #14195]" alone (indented) on the
> first line of the entry.  The text of the entry should be properly
> punctuated, and it must say something meaningful about what changed.

Attachment: strncasecmp_fix.patch
Description: Binary data