This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix linker-debugger interface

From: Carlos O'Donell <carlos_odonell at mentor dot com>
To: Roland McGrath <roland at hack dot frob dot com>
Cc: Gary Benson <gbenson at redhat dot com>, <libc-alpha at sourceware dot org>
Date: Thu, 16 Aug 2012 15:39:16 -0400
Subject: Re: [PATCH] Fix linker-debugger interface
References: <20120816154605.GC3467@redhat.com> <20120816163358.A52022C11E@topped-with-meat.com>

On 8/16/2012 12:33 PM, Roland McGrath wrote:
>> 2012-08-16  Gary Benson  <gbenson@redhat.com>
>>
>> 	* elf/dl-close.c (_dl_close_worker): Also set r->r_map when
>>           unmapping the first object in a namespace.
> 
> The second line should be intended with just one tab, so it lines up
> under the * of the first line.
> 
> Otherwise the change is fine.

I reviewed _dl_close_worker and the change looks correct.

I've often wondered if r_debug is correct in all cases and here's a
case where it isn't.

Are you able to check this in yourself?

Cheers,
Carlos.
-- 
Carlos O'Donell
Mentor Graphics / CodeSourcery
carlos_odonell@mentor.com
carlos@codesourcery.com
+1 (613) 963 1026

Follow-Ups:
- [committed] Fix linker-debugger interface
  - From: Gary Benson

References:
- [PATCH] Fix linker-debugger interface
  - From: Gary Benson
- Re: [PATCH] Fix linker-debugger interface
  - From: Roland McGrath

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]