Re: malloc probes for Systemtap

[Andreas Jaeger <aj at suse dot com>]

On Tuesday, September 04, 2012 20:39:46 Alexandre Oliva wrote:
> I was asked to introduce probes in malloc to aid in debugging cases in
> which our memory allocation code performs poorly.
> 
> I've grouped the probes in separate patches, in which the probes are
> logically connected.  I'd appreciate feedback on the soundness of the
> probe set: did I miss anything in these groups that is worth probing?
> is any of the probes uselessly redundant?  are they desirable at all?
> 
> Are they ok for master?  Do the docs look reasonable, description and
> formatting-wise?  (The only other probe docs I found in glibc were in
> elf/rtld-debugger-interface.txt)
> 
> The version of the patchset I pushed to lxoliva/malloc-probes-bz742038
> depends on Siddhesh's patch that introduces get_another_arena. 
> Although I've just suggested changes to it, I decided to post the
> patchset as it is, since most of it applies cleanly anyway, and
> regardless of adjustments needed for Siddhesh's patch, I suspect we
> might go through more than one round of review before my patchset can
> go in anyway.

Alexandre, the overall structure of the patch looks fine. Thanks for 
adding documentation as well.

Roland is the systemtap expert and I'd like him to review this - he's 
offline right now and I assume he'll answer next week,

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126