This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Make bindresvport() function to multithread-safe

From: Mike Frysinger <vapier at gentoo dot org>
To: libc-alpha at sourceware dot org
Cc: Peng Haitao <penght at cn dot fujitsu dot com>,Ulrich Drepper <drepper at gmail dot com>
Date: Mon, 17 Sep 2012 15:04:43 -0400
Subject: Re: [PATCH] Make bindresvport() function to multithread-safe
References: <4F3DED0D.7050504@cn.fujitsu.com>

On Friday 17 February 2012 01:00:45 Peng Haitao wrote:
> @@ -64,6 +70,8 @@ bindresvport (int sd, struct sockaddr_in *sin)
>        return -1;
>      }
> 
> +  __libc_lock_lock (lock);
> +
>    if (port == 0)
>      {
>        port = (__getpid () % NPORTS) + STARTPORT;

should the lock be acquired here ?  or should it be moved to right before the 
"again" label ?  i think the latter ...
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Follow-Ups:
- Re: [PATCH] Make bindresvport() function to multithread-safe
  - From: Peng Haitao

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]