This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Use unsigned long int in __bswap_64 for __WORDSIZE == 64

From: Roland McGrath <roland at hack dot frob dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Thu, 11 Oct 2012 13:16:02 -0700 (PDT)
Subject: Re: PATCH: Use unsigned long int in __bswap_64 for __WORDSIZE == 64
References: <20121011124402.GA2085@gmail.com><20121011171520.B58FA2C06F@topped-with-meat.com><CAMe9rOpwDdxuc1vRy=PpqaUGPCcjcjE1aM8spyO15SOR0i5oKQ@mail.gmail.com>

> I don't think it is worth the complexity since there is a check
> for __WORDSIZE already.

I consider it less complexity than repeating a function definition.
It also will make for a simple and obvious change if we later conclude
that just using uint64_t directly is an OK thing to do.


Thanks,
Roland

Follow-Ups:
- Re: PATCH: Use unsigned long int in __bswap_64 for __WORDSIZE == 64
  - From: H.J. Lu

References:
- PATCH: Use unsigned long int in __bswap_64 for __WORDSIZE == 64
  - From: H.J. Lu
- Re: PATCH: Use unsigned long int in __bswap_64 for __WORDSIZE == 64
  - From: Roland McGrath
- Re: PATCH: Use unsigned long int in __bswap_64 for __WORDSIZE == 64
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]