This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Sharing of bits/fcntl.h on Linux (SPARC, x86)
On 10/18/2012 12:17 AM, Roland McGrath wrote:
2012-10-17 Andreas Jaeger <aj@suse.de>
> [...]
Thanks for the review, I made all the suggested changes.
--- a/sysdeps/unix/sysv/linux/x86/bits/fcntl.h
+++ b/sysdeps/unix/sysv/linux/x86/bits/fcntl.h
[...]
@@ -25,57 +25,12 @@
# include <bits/uio.h>
#endif
Both the #include's belong in the common file.
The machine-specific file should have nothing but macro and type definitions.
This is not going to work directly since struct flock needs the include
of <sys/types.h> for __off64_t.
I have two options:
* Move the include of <bits/fcntl-linux.h> before the declaration of
struct flock and move all includes as you suggest.
* move only the include of <bits/uio.h>
What do you prefer?
I didn't actually check that all the bit values match.
I'll double check them now,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126