Re: [PATCH v3] change ifunc assembly test to a link test

[Mike Frysinger <vapier at gentoo dot org>]

On Wednesday 24 October 2012 13:12:35 Roland McGrath wrote:
> >  # For the multi-arch option we need support in the assembler.
> >  AC_CACHE_CHECK([for assembler gnu_indirect_function symbol type
> >  support],
> > 
> > -	       libc_cv_asm_gnu_indirect_function, [dnl
> > +	       libc_cv_ld_gnu_indirect_function, [dnl
> 
> You forgot to change the message (and the comment):

i thought you were referring to the commit message before.  oh well, v4 will 
be up shortly.

> > +  # Do a link to see if the backend supports IFUNC relocs.
> > +  $READELF -r conftest 1>&AS_MESSAGE_LOG_FD
> > +  LC_ALL=C $READELF -r conftest | grep 'no relocations' >/dev/null || {
> > +    libc_cv_ld_gnu_indirect_function=yes
> > +  }
> 
> This is subject to false-negatives if there is some unexpected weirdness
> with readelf or something.  But I'm not too concerned.

yeah, that's why i sent the full readelf output to the log to make it easy to 
diagnose in the future.  i checked x86_64/arm/ia64 to make sure it was OK.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.