This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Properly handle indirect functions in ABI check on powerpc64
On Wed, Nov 28, 2012 at 9:52 AM, Andreas Jaeger <aj@suse.com> wrote:
> On 11/28/2012 03:48 PM, Carlos O'Donell wrote:
>>
>> On Wed, Nov 28, 2012 at 4:25 AM, Andreas Schwab <schwab@suse.de> wrote:
>>>
>>> On ppc64 function symbols are always in .opd.
>>>
>>> Andreas.
>>>
>>> * scripts/abilist.awk: Also handle indirect functions in .opd
>>> section.
>>
>>
>> I'm curious, what does this break?
>
>
> make check on powerpc64 fails with:
>
> [ 3571s] ---
> ../sysdeps/unix/sysv/linux/powerpc/powerpc64/nptl/librt.abilist2012-11-27
> 19:30:50.000000000 +0000
> [ 3571s] +++
> /home/abuild/rpmbuild/BUILD/glibc-2.16.90/cc-base/rt/librt.symlist2012-11-28
> 04:28:42.000000000 +0000
> [ 3571s] @@ -18,5 +17,0 @@ GLIBC_2.3
> [ 3571s] - clock_getcpuclockid F
> [ 3571s] - clock_getres F
> [ 3571s] - clock_gettime F
> [ 3571s] - clock_nanosleep F
> [ 3571s] - clock_settime F
> [ 3571s] @@ -31,0 +27,5 @@ GLIBC_2.3
> [ 3571s] +clock_getcpuclockid GLIBC_2.3 g ? iD .opd 0000000000000018
> [ 3571s] +clock_getres GLIBC_2.3 g ? iD .opd 0000000000000018
> [ 3571s] +clock_gettime GLIBC_2.3 g ? iD .opd 0000000000000018
> [ 3571s] +clock_nanosleep GLIBC_2.3 g ? iD .opd 0000000000000018
> [ 3571s] +clock_settime GLIBC_2.3 g ? iD .opd 0000000000000018
> [ 3571s] make[2]: *** [check-abi-librt] Error 1
That makes sense. Thanks.
I knew function descriptors were stored in .opd on Power, but I didn't
think that affected anything in the testsuite.
The patch looks good to me then.
Cheers,
Carlos.