This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove `attr != NULL' assert in allocate_stack.
- From: "Carlos O'Donell" <codonell at redhat dot com>
- To: "Carlos O'Donell" <codonell at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 11 Jan 2013 20:54:20 -0500
- Subject: Re: [PATCH] Remove `attr != NULL' assert in allocate_stack.
- References: <50EF9722.6050105@redhat.com>
On 01/10/2013 11:37 PM, Carlos O'Donell wrote:
> The allocate_stack function is an internal function that is used
> only by glibc and only from pthread_create. We don't need an
> assert on a value we control and we know to be non-NULL. Just
> like we don't assert that pdp is non-NULL, or any other number
> of input arguments we control entirely.
>
> However, the function does need documenting that neither of
> the input arguments should be NULL.
>
> No regressions on x86_64.
>
> OK to commit?
>
> 2012-01-10 Carlos O'Donell <codonell@redhat.com>
>
> * allocatestack.c (allocate_stack): Remove assert for attr.
Committed.
Cheers,
Carlos.