This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] avoid stat/fstat in statvfs/fstatvfs
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Eric Wong <normalperson at yhbt dot net>
- Cc: libc-alpha at sourceware dot org, bug-gnulib at gnu dot org, Paul Eggert <eggert at cs dot ucla dot edu>
- Date: Thu, 7 Feb 2013 15:37:51 -0800 (PST)
- Subject: Re: [PATCH] avoid stat/fstat in statvfs/fstatvfs
- References: <20130130012802.GA17145@dcvr.yhbt.net><51088432.3070502@cs.ucla.edu><20130130024456.GA658@dcvr.yhbt.net><5108973C.5020408@cs.ucla.edu><20130130084928.GA23666@dcvr.yhbt.net><20130201023510.GA22735@dcvr.yhbt.net><20130207204628.BAFD22C096@topped-with-meat.com><20130207233201.GA6865@dcvr.yhbt.net>
The patch itself now looks fine to me. The log entry is inadequate.
It needs to mention each file and function touched and say what was
done there. "Update caller." is sufficient text for a function to
which the only change was trivial argument reordering or whatnot. But
in most of these cases, each caller dropped a stat* call as well and
so it needs to say "Pass it -1 instead of calling stat64." or suchlike.
Thanks,
Roland