This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] handle EPROTOTYPE for socket invocations with SOCK_* flags

From: Roland McGrath <roland at hack dot frob dot com>
To: Pino Toscano <toscano dot pino at tiscali dot it>
Cc: libc-alpha at sourceware dot org
Date: Thu, 7 Feb 2013 16:22:28 -0800 (PST)
Subject: Re: [PATCH] handle EPROTOTYPE for socket invocations with SOCK_* flags
References: <201302062048.23106.toscano.pino@tiscali.it><201302072328.42024.toscano.pino@tiscali.it><20130207230858.9C0D72C098@topped-with-meat.com><201302080118.58632.toscano.pino@tiscali.it>

> OK.  Before I send a new, possibly rejected, version of the patch, are 
> there further comments on the actual function itself (naming, style, 
> content, etc) and its use?

The name is poor.  It doesn't tell me anything about what it's actually for.
And there should be a comment on the definition describing its purpose.
I don't see any other issues off hand, but watch out for lines >79 columns.


Thanks,
Roland

References:
- [PATCH] handle EPROTOTYPE for socket invocations with SOCK_* flags
  - From: Pino Toscano
- Re: [PATCH] handle EPROTOTYPE for socket invocations with SOCK_* flags
  - From: Pino Toscano
- Re: [PATCH] handle EPROTOTYPE for socket invocations with SOCK_* flags
  - From: Roland McGrath
- Re: [PATCH] handle EPROTOTYPE for socket invocations with SOCK_* flags
  - From: Pino Toscano

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]