This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [ping][PATCH][s390][ppc] Add REQUEUE_PI support
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: "Ryan S. Arnold" <ryan dot arnold at gmail dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Mon, 18 Feb 2013 09:04:20 +0530
- Subject: Re: [ping][PATCH][s390][ppc] Add REQUEUE_PI support
- References: <20130108132702.GD27464@spoyarek.pnq.redhat.com><20130114152715.GG7894@spoyarek.pnq.redhat.com><CAAKybw-huQzmqknNfDbTZy-TBiG-MgM70gvWAc=D2SQzPfGRig@mail.gmail.com>
On Fri, Feb 15, 2013 at 05:50:50PM -0600, Ryan S. Arnold wrote:
> I don't really understand this code base well enough to give you a
> worthwhile review.
>
> Does the test-suite cover all of the corner cases that this code exposes?
Yes, I had written test cases while fixing corner case bugs for PI
mutex backed condition variables on x86 and those should work for all
architectures that implement this.
> In principle I don't see a problem with the code, and I don't want to
> be overly conservative. I think it can go in if there are no
> regressions and I'll have my team try to stress the mechanism a bit.
Thanks, I'll commit this today. I'll send out a separate email on
libc-ports announcing this so that other architectures can implement
PI support using this code.
Siddhesh