This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] [v2] Add Comment to io/fcntl.h


> +/* The constants AT_REMOVEDIR and AT_EACCESS have the same value.  The
> +   AT_EACCESS value is only used by faccessat() and the AT_REMOVEDIR value is
> +   only used by unlinkat().  The two functions do completely different things
> +   and therefore the flags can be allowed to overlap.  For example, passing
> +   AT_REMOVEDIR to faccessat() would be undefined behavior and thus treating
> +   it equivalent to AT_EACCESS is valid undefined behavior.  */

Don't use "()" in text.  It's not part of English syntax.

Saying, "The FOO value is only used..." seems odd to me.  I would have
written something like, "AT_EACCESS is meaningful only to faccessat, while
AT_REMOVEDIR is meaningful only to unlinkat."


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]