This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/9] Add the low level infrastructure for pthreads lock elision with TSX
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Andi Kleen <ak at linux dot intel dot com>
- Cc: Andreas Jaeger <aj at suse dot com>, libc-alpha at sourceware dot org
- Date: Wed, 15 May 2013 16:02:42 -0400
- Subject: Re: [PATCH 2/9] Add the low level infrastructure for pthreads lock elision with TSX
- References: <1368225725-14283-1-git-send-email-andi at firstfloor dot org> <1368225725-14283-3-git-send-email-andi at firstfloor dot org> <518F5B45 dot 6080301 at suse dot com> <20130513223037 dot GG4072 at tassilo dot jf dot intel dot com> <5191E43C dot 7070602 at suse dot com> <5191E770 dot 80105 at redhat dot com> <20130515183422 dot GL4072 at tassilo dot jf dot intel dot com> <5193DAF9 dot 1000602 at redhat dot com> <20130515190409 dot GM4072 at tassilo dot jf dot intel dot com>
On 05/15/2013 03:04 PM, Andi Kleen wrote:
>> Everything in the library should be localized unless we have a
>> good reason not to including that the services aren't available
>> to us at the point at which our code runs.
>
> Sorry. I don't want to deal with this. I already wasted
> far too much time on debugging pthread init ordering problems.
>
> I will just remove the messages.
The messages you have are better than no message at all,
please leave them in.
A "good reason" includes not having enough time to do
the work, when we checkin the code remind me to file
a bug to try get those strings localized.
Cheers,
Carlos.