Re: [PATCH rsa/stdint_noheaders] Cleanup: Add #include <stdint.h> for uint[32|64]_t usage (except installed headers)

[Thomas Schwinge <thomas at codesourcery dot com>]

Hi!

On Thu, 16 May 2013 11:40:14 -0500, "Ryan S. Arnold" <ryan.arnold@gmail.com> wrote:
> On Thu, May 16, 2013 at 8:58 AM, Ryan S. Arnold <ryan.arnold@gmail.com> wrote:
> > On Thu, May 16, 2013 at 8:36 AM, OndÅej BÃlka <neleai@seznam.cz> wrote:
> >> On Wed, May 01, 2013 at 11:23:39AM -0500, Ryan Arnold wrote:
> >>> Per Roland's suggestion in "[PATCH rsa/stdint] Cleanup: Add #include
> >>> <stdint.h> for uint[32|64]_t usage" I have removed the installed headers
> >>> from this patch, and separated the ChangeLog entries into the proper
> >>> subdirectory ChangeLogs.

> Pushed upstream:
> 
> commit e054f494306530720114b321b3d97ca2f397cbbb
> Author: Ryan S. Arnold <rsa@linux.vnet.ibm.com>
> Date:   Wed May 1 10:46:34 2013 -0500
> 
>     Add #include <stdint.h> for uint[32|64]_t usage (except installed headers).

I'm seeing:

    make[2]: Entering directory `[...]/locale'
    /usr/bin/perl gen-translit.pl < C-translit.h.in > C-translit.h.tmp
    mv -f C-translit.h.tmp C-translit.h

..., resulting in:

diff --git locale/C-translit.h locale/C-translit.h
index 98f66e2..d7ec778 100644
--- locale/C-translit.h
+++ locale/C-translit.h
@@ -1,5 +1,3 @@
-#include <stdint.h>
-
 #define NTRANSLIT 1355
 static const uint32_t translit_from_idx[] =
 {

Should a) the change be reverted for this file (that is, the above hunk
be applied), or b) the generator be changed to emit that #include, or,
heck, c) the autogenerated file be removed from the source repository
(and then some)?


GrÃÃe,
 Thomas

Attachment: pgprvYjNaKM1D.pgp
Description: PGP signature