This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] [BZ #10283] localedef: align fixed maps to SHMLBA
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 28 May 2013 18:37:58 -0400
- Subject: Re: [PATCH v2] [BZ #10283] localedef: align fixed maps to SHMLBA
- References: <1369327649-906-1-git-send-email-vapier at gentoo dot org> <1369507293-19498-1-git-send-email-vapier at gentoo dot org> <51A50663 dot 20306 at redhat dot com> <201305281805 dot 15814 dot vapier at gentoo dot org>
On 05/28/2013 06:05 PM, Mike Frysinger wrote:
> On Tuesday 28 May 2013 15:32:51 Carlos O'Donell wrote:
>> On 05/25/2013 02:41 PM, Mike Frysinger wrote:
>>> +#define PTR_ALIGN_UP(base, size) \
>>> + (void *) ALIGN_UP ((uintptr_t) (base), (size))
>>
>> Almost done.
>>
>> We install cdefs.h and thus these macros need __ to avoid being
>> in the user's namespace.
>
> not exactly. i picked include/sys/cdefs.h instead of misc/sys/cdefs.h because
> the latter is for installing while the former is for internal use.
My mistake.
>> The benefit is that we'll be able to use them *everywhere*,
>> even in macros in headers we expose to userspace, which
>> is what we want.
>
> i'm not sure. maybe wait for such consumers to show up before we export ?
Agreed. I'm fine with that.
Cheers,
Carlos.