This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3.1] New functions pthread_[sg]etattr_default_np for default thread attributes
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: Roland McGrath <roland at hack dot frob dot com>, libc-alpha at sourceware dot org
- Date: Thu, 13 Jun 2013 18:35:41 +0530
- Subject: Re: [PATCH v3.1] New functions pthread_[sg]etattr_default_np for default thread attributes
- References: <CAAHN_R13bRF0UY_XZ7Rj6tSeSgq8c_0j4bbEH6m9BbGD32EycQ at mail dot gmail dot com> <20130528220730 dot 33C262C06F at topped-with-meat dot com> <20130529065138 dot GF2145 at spoyarek dot pnq dot redhat dot com> <20130529224222 dot 8A87F2C07E at topped-with-meat dot com> <20130606131212 dot GZ13968 at spoyarek dot pnq dot redhat dot com> <20130612000601 dot 54C9F2C06E at topped-with-meat dot com> <20130612101128 dot GB19582 at spoyarek dot pnq dot redhat dot com> <20130612231757 dot CCC752C07F at topped-with-meat dot com> <20130613022810 dot GJ19582 at spoyarek dot pnq dot redhat dot com> <Pine dot LNX dot 4 dot 64 dot 1306131240490 dot 10141 at digraph dot polyomino dot org dot uk>
On Thu, Jun 13, 2013 at 12:42:09PM +0000, Joseph S. Myers wrote:
> On Thu, 13 Jun 2013, Siddhesh Poyarekar wrote:
>
> > It was agreed in the past that test warnings such as skipping a case
> > should be printing on standard error so that it is visible in the make
> > check output:
> >
> > http://sourceware.org/glibc/wiki/Testing/Testsuite#Writing_a_test_case
>
> I think that's a bad idea. In practice what goes in the test's .out file
> is *more* visible than what goes in the huge pile of make check output.
> Arguably stderr as well as stdout should be redirected.
IIRC the rationale behind that was that such warnings go unnoticed and
it is assumed that all tests *passed* when in reality some may have
been skipped. I think [1] may have been the point where I had noted
this in the wiki, but I'm not sure. It's a trivial detail, so if you
or Roland feel strongly about this then I can change these bits.
Siddhesh
[1] http://cygwin.com/ml/libc-alpha/2012-07/msg00615.html