This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: TSX lock elision for glibc v11
- From: Andi Kleen <andi at firstfloor dot org>
- To: Torvald Riegel <triegel at redhat dot com>
- Cc: Andi Kleen <andi at firstfloor dot org>, libc-alpha at sourceware dot org
- Date: Fri, 14 Jun 2013 19:31:59 +0200
- Subject: Re: TSX lock elision for glibc v11
- References: <1371228488-11421-1-git-send-email-andi at firstfloor dot org> <1371230622 dot 16968 dot 20416 dot camel at triegel dot csb>
On Fri, Jun 14, 2013 at 07:23:42PM +0200, Torvald Riegel wrote:
> > or prevent any
> > any elision nesting, as they would make the project useless
> > and the rationale was too weak.
> > I didn't separate the trylock changes into new flags, as that seemed too ugly
> > and overengineered, and the rationale was also weak.
> > I did only do a subset identifier/comment changes requested, as for many
> > there was no good rationale to do so, and my arbitary choice is as good
> > as someone else's. The biggest change was __elided -> __rw_elision for
> > read locks.
>
> Review comments aren't suggestions. They are issues that need to be
I didn't comment on every variable/comments change I did not make.
Naming conventions and commenting style is quite subjective,
in the (wide) boundaries of the GNU coding standard.
That said I did some of them, but not all.
I commented on all the other changes I didn't agree on
(primarily the NORMAL/DEFAULT change or disabling nested write lock
or the additional behaviour bit)
-Andi