This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/6] Add fmemopen compatibility version.
- From: Roland McGrath <roland at hack dot frob dot com>
- To: OndÅej BÃlka <neleai at seznam dot cz>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 14 Jun 2013 15:49:31 -0700 (PDT)
- Subject: Re: [PATCH 2/6] Add fmemopen compatibility version.
- References: <1370099488-13916-1-git-send-email-neleai at seznam dot cz> <1370099488-13916-3-git-send-email-neleai at seznam dot cz> <20130611232846 dot A9B452C07D at topped-with-meat dot com> <20130612053943 dot GA14157 at domone dot kolej dot mff dot cuni dot cz>
> On Tue, Jun 11, 2013 at 04:28:46PM -0700, Roland McGrath wrote:
> > Why do you want to copy the entire implementation? So far it's only the
> > seek function that needs to differ. Other fixes you've proposed are not
> > ones we want to keep out of the implementation of the old symbol version.
> >
> > I'd do it in fmemopen.c, splitting fmemopen into a local subroutine that
> > takes the seek function as an argument.
>
> Not only this,
One thing at a time. Do the clean change for the seek fix, and then we can
iterate from there.
> [PATCH 7/6][BZ #11216] Return fmemopen stream when len==0
> In bugzilla there was concern for backward compatibility.
That too is easy to do in the compatibility entry point without duplicating
anything else.
> A
> [PATCH 6/6][BZ #13152] fmemopen does not honor append mode.
> changes cookie structure, I versioning may be needed here.
That is an implementation detail that is wholly opaque to the user.
Thanks,
Roland