This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATH] [BZ 15674] Fix reading past the array boundary in __memcmp_ssse3
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Liubov Dmitrieva <liubov dot dmitrieva at gmail dot com>, Andreas Schwab <schwab at suse dot de>, Richard Henderson <rth at twiddle dot net>, "Carlos O'Donell" <carlos at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 26 Jun 2013 13:04:30 -0700 (PDT)
- Subject: Re: [PATH] [BZ 15674] Fix reading past the array boundary in __memcmp_ssse3
- References: <CAHjhQ92DBAVCozvunaCNhRgswUHcQL42Yc24pieVVU=GGBFrww at mail dot gmail dot com> <51C9BC0F dot 6030201 at twiddle dot net> <CAHjhQ93TsPdmRNvS4YbwELi3OPCFmE4AU_v97Br5xmQY86L=gA at mail dot gmail dot com> <mvmsj05kq0a dot fsf at hawking dot suse dot de> <CAHjhQ90-YhzAwOUcrkj_d_Q+KWPie4PTbmPLZ5DRyCQH5CH7fg at mail dot gmail dot com> <CAMe9rOr-jPTP4z6=_3zzjiTvSUtOrB68KHVPp9tXpNkU_6SAaQ at mail dot gmail dot com> <CAMe9rOriLnQFGU9QUDosRcQwOZ+2Od77XUsFL5T-XH7qgqLb9w at mail dot gmail dot com> <CAMe9rOp++9bW8kN=shbFCdWp9x_BYT+Wb+BZLP9Hs=bAyC_5bA at mail dot gmail dot com>
> + int max_length = page_size / sizeof (CHAR);
size_t.
> + CHAR * buf = (CHAR *) buf2;
No space after *.
> + int length;
> +
> + for (length = 1; length < max_length; length++)
for (size_t length = ...
> + {
> + CHAR * s1 = (CHAR *) buf1 + max_length - length;
> + CHAR * s2 = (CHAR *) buf + max_length - length;
No space after *.