Re: [PATCH 1/2 v3] tst-fanotify: new simple test

[Mike Frysinger <vapier at gentoo dot org>]

On Tuesday 03 September 2013 08:59:52 Adhemerval Zanella wrote:
> The minimum supported Linux kernel version for current GLIBC is 2.6.16 and
> fanotify was added int 2.6.36 and enabled in 2.6.37. The test build is
> failing on older kernels that does not provides "linux/fanotify.h" (RHEL6
> for instance). You will need to either disable the test altogether or sets
> it to return a dummy value if the kernel does not supports it.

hmm, i think this should fix it by using the gnu/stubs.h rather than doing an
explicit header check.
-mike

--- a/sysdeps/unix/sysv/linux/tst-fanotify.c
+++ b/sysdeps/unix/sysv/linux/tst-fanotify.c
@@ -19,6 +19,18 @@
 #include <errno.h>
 #include <fcntl.h>
 #include <stdio.h>
+
+#ifdef __stub_fanotify_init
+
+static int
+do_test (void)
+{
+  puts ("SKIP: missing support for fanotify due to old kernel headers");
+  return 0;
+}
+
+#else
+
 #include <sys/fanotify.h>
 
 static int
@@ -52,5 +64,7 @@ do_test (void)
   return 0;
 }
 
+#endif
+
 #define TEST_FUNCTION do_test ()
 #include "../test-skeleton.c"

Attachment: signature.asc
Description: This is a digitally signed message part.