This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] build: don't use attribute((leaf)) on static functions

From: Eric Blake <eblake at redhat dot com>
To: Mike Frysinger <vapier at gentoo dot org>
Cc: libc-alpha at sourceware dot org
Date: Wed, 02 Oct 2013 16:37:09 -0600
Subject: Re: [PATCH] build: don't use attribute((leaf)) on static functions
Authentication-results: sourceware.org; auth=none
Openpgp: url=http://people.redhat.com/eblake/eblake.gpg
References: <1380677884-32469-1-git-send-email-eblake at redhat dot com> <201310021403 dot 09963 dot vapier at gentoo dot org>

On 10/02/2013 12:03 PM, Mike Frysinger wrote:
> On Tuesday 01 October 2013 21:38:04 Eric Blake wrote:
>> Remember, attribute((leaf)) makes sense only for extern
>> functions, and as some versions of gcc warn about its use
>> on static functions, using __THROWNL for those will have
>> no change in intended semantics.
> 
> seems worthy of adding to `make check` ?

Indeed - but how do I go about doing that?  It looks like there are a
couple of existing syntax-checker style rules - if I create a new file
scripts/check-*, will it automatically get run by 'make check'?  I'm not
familiar enough with the glibc layout to know where to begin tackling
this.  Help would be appreciated.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

References:
- [PATCH] build: don't use attribute((leaf)) on static functions
  - From: Eric Blake
- Re: [PATCH] build: don't use attribute((leaf)) on static functions
  - From: Mike Frysinger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]