This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Update generic swapon definition to match prototype.
- From: Ryan Arnold <ryan dot arnold at linaro dot org>
- To: libc-alpha <libc-alpha at sourceware dot org>
- Cc: Patch Tracking <patches at linaro dot org>
- Date: Fri, 4 Oct 2013 12:32:09 -0500
- Subject: Re: [PATCH] Update generic swapon definition to match prototype.
- Authentication-results: sourceware.org; auth=none
- References: <ryan dot arnold at linaro dot org> <1380835347-15537-1-git-send-email-ryan dot arnold at linaro dot org> <524E3B5D dot 4030404 at redhat dot com>
On Thu, Oct 3, 2013 at 10:51 PM, Carlos O'Donell <carlos@redhat.com> wrote:
> On 10/03/2013 05:22 PM, Ryan S. Arnold wrote:
>> From: "Ryan S. Arnold" <ryan.arnold@linaro.org>
>>
>> While building for an arch where I somehow wasn't building generated
>> syscalls I found out that the swapon.c definition doesn't match the
>> prototype in the header with regard to parameters.
>>
>> Ryan S. Arnold
>>
>> ---
>>
>> 2013-10-03 Ryan S. Arnold <ryan.arnold@linaro.org>
>>
>> * misc/swapon.c (swapon): Updated definition with FLAGS parameter to
>> match prototype.
>>
>> diff --git a/misc/swapon.c b/misc/swapon.c
>> index 61933b8..0e587d4 100644
>> --- a/misc/swapon.c
>> +++ b/misc/swapon.c
>> @@ -22,8 +22,7 @@
>> /* Make the block special device PATH available to the system for swapping.
>> This call is restricted to the super-user. */
>> int
>> -swapon (path)
>> - const char *path;
>> +swapon (const char *path, int flags)
>> {
>> __set_errno (ENOSYS);
>> return -1;
>>
>
> Looks correct to me.
Thanks.
Pushed as:
commit d39baad11e5092b56621902f8406c64c092a90dc
Author: Ryan S. Arnold <ryan.arnold@linaro.org>
Date: Fri Oct 4 12:07:04 2013 -0500
Update generic swapon definition to match prototype.