This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2.0][BZ #15670] Replace alloca in __tzfile_read by malloc.

From: Mike Frysinger <vapier at gentoo dot org>
To: OndÅej BÃlka <neleai at seznam dot cz>
Cc: libc-alpha at sourceware dot org, "Joseph S. Myers" <joseph at codesourcery dot com>
Date: Wed, 16 Oct 2013 22:43:42 -0400
Subject: Re: [PATCH 2.0][BZ #15670] Replace alloca in __tzfile_read by malloc.
Authentication-results: sourceware.org; auth=none
References: <20131014131522 dot GA23174 at domone dot podge> <20131014182409 dot GA28570 at domone dot podge> <20131016164040 dot GA17580 at domone dot podge>

On Wednesday 16 October 2013 12:40:40 OndÅej BÃlka wrote:
> @@ -173,6 +164,7 @@ __tzfile_read (const char *file, size_t extra, char
> **extrap) {
>        /* Nothing to do.  */
>        __use_tzfile = 1;
> +      free (new);
>        return;
>      }

i wonder if this would benefit from a "goto done" and then adding "done:" at 
the end ...

> @@ -528,11 +520,13 @@ __tzfile_read (const char *file, size_t extra, char
> **extrap) __timezone = -rule_stdoff;
> 
>    __use_tzfile = 1;
> +  free (new);
>    return;

this would get a new "done:" label

either way, LGTM
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Follow-Ups:
- Re: [PATCH 2.1][BZ #15670] Replace alloca in __tzfile_read by malloc.
  - From: OndÅej BÃlka

References:
- [PATCH][BZ #15670] Bound alloca in __tzfile_read.
  - From: OndÅej BÃlka
- Re: [PATCH][BZ #15670] Replace alloca in __tzfile_read by malloc.
  - From: OndÅej BÃlka
- [PATCH 2.0][BZ #15670] Replace alloca in __tzfile_read by malloc.
  - From: OndÅej BÃlka

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]