This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Async signal safe TLS accesses

From: Paul Pluzhnikov <ppluzhnikov at google dot com>
To: "Joseph S. Myers" <joseph at codesourcery dot com>
Cc: Andrew Hunter <ahh at google dot com>, libc-alpha at sourceware dot org
Date: Thu, 7 Nov 2013 11:30:00 -0800
Subject: Re: [PATCH] Async signal safe TLS accesses
Authentication-results: sourceware.org; auth=none
References: <1380830518-16721-1-git-send-email-ahh at google dot com> <1382477766-15770-1-git-send-email-ahh at google dot com> <Pine dot LNX dot 4 dot 64 dot 1310222145490 dot 13258 at digraph dot polyomino dot org dot uk> <CALoOobMsO6X86JFD4J7F-EL-J+xOTEOVbzH=6mwrvfCnFvw57Q at mail dot gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1311052233090 dot 30260 at digraph dot polyomino dot org dot uk> <CALoOobM70-mix+=1zuDnSoK7SRqQChbL=03xBkUcFf1fyS1Mjw at mail dot gmail dot com> <CALoOobP7kdpZCZA0a7MZWCtONu81fW4H_qAWOEfpfvzxJgG_=Q at mail dot gmail dot com>

On Wed, Nov 6, 2013 at 6:50 PM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:

> Breaks i686 build :-(

Fixed. Re-tested on Linux/x86_64 and i686, no new failures.

Thanks,
-- 
Paul Pluzhnikov

2013-11-07  Andew Hunter  <ahh@google.com>
            Paul Pluzhnikov  <ppluzhnikov@google.com>

        [BZ #16133]

        * elf/Versions (ld): Add _dl_clear_dtv.
        * elf/dl-misc.c (__signal_safe_memalign): New function.
        (__signal_safe_malloc, __signal_safe_free): Likewise.
        (__signal_safe_realloc, __signal_safe_calloc): Likewise.
        * elf/dl-open.c (dl_open_worker): Comment added.
        * elf/dl-reloc.c (_dl_try_allocate_static_tls): Adjust.
        (_dl_allocate_static_tls): Mask signals.
        * elf/dl-tls.c (allocate_dtv): Use signal-safe allocator.
        (_dl_deallocate_tls, allocate_and_init): Likewise.
        (_dl_update_slotinfo): Likewise.
        (_dl_clear_dtv): New.
        (tls_get_addr_tail): Adjust.
        * nptl/Makefile (tst-tls7): New test.
        * nptl/allocatestack.c (get_cached_stack): Adjust.
        (init_one_static_tls): Adjust.
        * nptl/tst-tls7.c: New test.
        * nptl/tst-tls7mod.c: New test.
        * sysdeps/generic/ldsodefs.h (_dl_mask_all_signals): New.
        (_dl_unmask_signals): Likewise.
        (__signal_safe_memalign, __signal_safe_malloc): Likewise.
        (__signal_safe_free, __signal_safe_realloc): Likewise.
        (__signal_safe_calloc, _dl_clear_dtv): Likewise.
        * sysdeps/mach/hurd/dl-sysdep.h (_dl_mask_all_signals): New stub.
        (_dl_unmask_all_signals): Likewise.
        * sysdeps/unix/sysv/linux/dl-sysdep.c (_dl_mask_all_signals):
        New function.
        (_dl_unmask_all_signals): Likewise.
        * sysdeps/unix/sysv/linux/dl-sysdep.h (_dl_mask_all_signals): New.
        (_dl_unmask_all_signals): Likewise.

Attachment: ahh-glibc-20131107.txt
Description: Text document

Follow-Ups:
- Re: [PATCH] Async signal safe TLS accesses
  - From: Paul Pluzhnikov
- Re: [PATCH] Async signal safe TLS accesses
  - From: Torvald Riegel

References:
- Re: [PATCH] Async signal safe TLS accesses
  - From: Paul Pluzhnikov
- Re: [PATCH] Async signal safe TLS accesses
  - From: Joseph S. Myers
- Re: [PATCH] Async signal safe TLS accesses
  - From: Paul Pluzhnikov
- Re: [PATCH] Async signal safe TLS accesses
  - From: Paul Pluzhnikov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]