This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][v2] Add dynamic linker support for $EXEC_ORIGIN.

On Thursday 12 December 2013 17:13:39 Brooks Moses wrote:
> --- a/elf/dl-dst.h
> +++ b/elf/dl-dst.h
>
> +	char *exec_origin = GLRO(dl_exec_origin_path);			      \

shouldn't that be const ?

i've always wondered why the "space before (" rule doesn't apply to 
GLRO/INTUSE macros.

> --- a/elf/rtld.c
> +++ b/elf/rtld.c
> 
> +static void set_exec_origin_path(const char *exe_path);

space before the (

otherwise, looks OK, but probably should get sign off from someone more 
familiar with the ldso code
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]