This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] PowerPC: Fix gettimeofday ifunc selection
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
- Date: Tue, 14 Jan 2014 09:11:30 -0500
- Subject: Re: [PATCH] PowerPC: Fix gettimeofday ifunc selection
- Authentication-results: sourceware.org; auth=none
- References: <52D4333A dot 1080805 at linux dot vnet dot ibm dot com> <CAJE4xBPVc8SwzXoR1T=u71v5weYmoJx_etuFcG3WaA1YpHb+1w at mail dot gmail dot com> <52D51BE8 dot 4020306 at linux dot vnet dot ibm dot com> <52D542D0 dot 3050303 at redhat dot com> <52D543F5 dot 9070106 at linux dot vnet dot ibm dot com>
On 01/14/2014 09:04 AM, Adhemerval Zanella wrote:
>>>> Did the testcase used to discover the bug from
>>>> https://sourceware.org/bugzilla/show_bug.cgi?id=16430 make it
>>>> into the tree?
>>>>
>>>> Ryan
>>>>
>>> GLIBC does not have a similar testcase and I think it is not
>>> usual to add testcase in code freeze.
>> We should always be adding a regression test to any bug we fix.
>>
>> The code freeze is meant to prevent new destabilizing features from
>> being added.
>>
>> You shouldn't add a test that is an expected fail though.
>>
>> Cheers, Carlos.
>>
> Indeed and I was meant to add a testcase after the code freeze.
> However, if it were consensus I will work on adding a testcase
> (although the 16430 testcase it not really stressing this issue).
I think it is general consensus that adding a regression test is
always the right thing to do.
In the past for tests that were XFAIL we removed them until the
fix was put into place (mainly becuase glibc lacks a decent
test infrastructure).
I don't dictate what you work on though. A fix is a fix, and it
should go in. We'd also like a regression test, but you are free
to say no.
Cheers,
Carlos.