This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] fix bz #16169 - CFI directives missing from AArch64 clone.S
- From: Ryan Arnold <ryan dot arnold at linaro dot org>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>, Marcus Shawcroft <marcus dot shawcroft at linaro dot org>
- Date: Mon, 20 Jan 2014 12:34:55 -0600
- Subject: Re: [PATCH] fix bz #16169 - CFI directives missing from AArch64 clone.S
- Authentication-results: sourceware.org; auth=none
- References: <1389904266-22061-1-git-send-email-tromey at redhat dot com> <CAFqB+PyQrkRTm72M9S_+KGOMsfo8du-ExOTk2zedfptenpHHgg at mail dot gmail dot com> <CAJE4xBMfaHSRc9t0srsEBzMe=3HwLkWLfH0KJYP4FMRAfe0kHg at mail dot gmail dot com> <87ob37hy8e dot fsf at fleche dot redhat dot com>
On Mon, Jan 20, 2014 at 2:08 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Ryan" == Ryan Arnold <ryan.arnold@linaro.org> writes:
>
> Ryan> I finally got access to an environment where I could test this and
> Ryan> came up with the same fix you did for cfi_undefined (x30).
>
> Ryan> I ran a modified version of nptl/tst-align2 to hit the error syscall
> Ryan> error path but wasn't able to get gdb to hang as Tom described either
> Ryan> before or after the fix was applied. I was using ni and bt while
> Ryan> broken inside of __clone. Perhaps that's not how he hit the condition
> Ryan> in the first place, but he'll have to elaborate.
>
> The initial report was here:
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=16155
>
> You may need to try an older gdb to reproduce the problem; the bug
> causing gdb to hang was fixed in a way that hides the missing CFI
> problem here. I still think it's correct to add these CFI directives,
> though.
>
> Tom
Thanks Tom,
I think it's the right fix too.
Ryan